HomePhabricator
Diffusion Comm a31d3a6af675

[web] Fix message tooltip layout
a31d3a6af675
Actions

Description

[web] Fix message tooltip layout

Summary:
This fixes an issue in D740 (see my last comment there) and rethinks/simplifies the HTML/CSS layout we're using. I think the code is now a good bit simpler and easier to reason about, and the bug no longer occurs.

See inline comments for more details.

Test Plan: Test a bunch of different kinds of messages

Reviewers: KatPo, atul, palys-swm

Subscribers: zrebcu411, Adrian, subnub

Differential Revision: https://phabricator.ashoat.com/D867

Details

Provenance
ashoatAuthored on Mar 5 2021, 4:03 PM
Differential Revision
Restricted Differential Revision
Parents
rCOMM3918e98b6152: [lib] Make sure bottom-right corner of pending sidebar message is rounded
Branches
Unknown
Tags
Unknown

Event Timeline

ashoat committed rCOMMa31d3a6af675: [web] Fix message tooltip layout (authored by ashoat).Mar 5 2021, 4:32 PM
ashoat added an edge: Restricted Differential Revision.

Changes (5)

PathSize
web/
chat/

rCOMMa31d3a6af675

View Options

web/chat/chat-message-list.css

Loading...
View Options

web/chat/composed-message.react.js

Loading...
View Options

web/chat/message-reply-tooltip.react.js

Loading...
View Options

web/chat/robotext-message.react.js

Loading...
View Options

web/chat/sidebar-tooltip.react.js

Loading...