HomePhabricator
Diffusion Comm b2101013d555

[web] Fix reset password modal not closing bug

Description

[web] Fix reset password modal not closing bug

Test Plan:

  • Checked if pressing update/submit password, and when navigated to /calendar, closes the modal properly.
  • Checked if navigating to the verify URL when the modal is first popped up that the URL stays on verify instead of navigating back home (/)
  • Checked if the bug that navigates to a URL such as /calendar/verify/{id} is no longer present.
  • Checked if navigate to a reset URL when the token was already used, if it still says the token invalid. And if closing the modal still worked.
  • Checked if closing the reset password modal without submitting still worked, and that it navigated to the correct URL.
  • Checked if trying to reset the password when already logged in doesn’t cause any errors when submitting.
  • Checked if trying to reset password when already logged in, and instead closing the modal to make sure onClose still worked
  • Checked if the user is still able to navigate to /calendar and can navigate to threads.
  • Checked if refreshing a page on a thread still takes the user to that thread
  • Used the chrome network throttling tool to check how the URL redirects work now, and that they all navigate to the correct URL.

I also added a video of the modal closing on notion, and added a flow chart.

Reviewers: palys-swm, atul, subnub

Reviewed By: subnub

Subscribers: ashoat, KatPo, zrebcu411, Adrian, atul

Differential Revision: https://phabricator.ashoat.com/D913

Details

Provenance
subnubAuthored on Mar 21 2021, 7:09 PM
ashoatCommitted on Mar 22 2021, 8:04 PM
Reviewer
subnub
Differential Revision
Restricted Differential Revision
Parents
rCOMMfee80fb54569: [server] Throw ServerError on malformed verification codes
Branches
Unknown
Tags
Unknown

Event Timeline