HomePhabricator
Diffusion Comm b2b658d80025

[native] fix missing threadInfo in thread settings

Description

[native] fix missing threadInfo in thread settings

Summary:
Logging out while sidebar settings are opened causes a crash.
https://linear.app/comm/issue/ENG-1721/

After logging out, we lose redux state and crash because threadInfo is undefined. In this case we should fall back onto threadInfo in the navigation params.

Test Plan:

  1. Check if the app doesn't crash after logging out with sidebar settings open.
  2. Check if the app doesn't crash with non-sidebar thread settings open.
  3. Check that if you change some value in settings (e.g. color) and log out, the settings screen that "blinks" for a moment has an updated value.

Reviewers: tomek, atul, abosh, ashoat

Reviewed By: ashoat

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D5142

Details

Provenance
Michal Gniadek <michal.gniadek@swmansion.com>Authored on Sep 14 2022, 7:05 AM
Reviewer
ashoat
Differential Revision
D5142: [native] fix missing threadInfo in thread settings
Parents
rCOMM6cccc466a2eb: [CI] Add identity pre-commit hook
Branches
Unknown
Tags
Unknown

Event Timeline