HomePhabricator
Diffusion Comm b656afcf2e70

[web] Fix sidebar title cutoff in `ChatThreadList`

Tags
None
Referenced Files
F76329: image.png
Jun 28 2022, 1:53 PM
File Not Attached
F76328: image.png
Jun 28 2022, 1:53 PM
File Not Attached
Subscribers
None

Description

[web] Fix sidebar title cutoff in ChatThreadList

Summary:
Linear issue with full context here.

Seems to be a regression, not sure when it was introduced exactly. This diff repositions the ChatThreadListItemMenu .menuSidebar div to be absolutely positioned so that it doesn't interfere with the ChatThreadListSidebar. Before, the ChatThreadListSidebar was being covered by the ChatThreadListItemMenu and it probably went unnoticed since it wasn't tested with a sidebar message that was long enough to trigger the ellipsis overflow.

Before:

image.png (342×794 px, 30 KB)

After:

image.png (634×804 px, 57 KB)

Test Plan: Looks as expected on Chrome/Safari and the ChatThreadListItemMenu still works as expected.

Reviewers: atul, ashoat, palys-swm

Reviewed By: ashoat

Subscribers: palys-swm, Adrian

Differential Revision: https://phab.comm.dev/D4284

Details

Provenance
aboshAuthored on Jun 16 2022, 12:24 PM
Reviewer
ashoat
Differential Revision
D4284: [web] Fix sidebar title cutoff in `ChatThreadList`
Parents
rCOMM403d473af2a5: [services] Add dev-mode to the services documentation
Branches
Unknown
Tags
Unknown