[lib] Fix state check with new ID schema

Summary:
https://linear.app/comm/issue/ENG-245/make-sure-state-sync-mechanism-works-after-client-id-migration
There was bug in the id schema conversion during the state check. The async function returned by the getClientResponsesSelector modified the arguments gotten from the input selectors. That meant if the async function was called multiple times (and redux state didn't change so it wasn't regenerated) it would try to convert the already converted state. This diff moves the conversion outside of the async function so it's done only once.

Test Plan: Check that if the state sync runs for the second time without redux changes no errors are thrown. (that was what was triggering the errors without this diff)

Reviewers: kamil, tomek

Reviewed By: kamil

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D8356