HomePhabricator
Diffusion Comm c04a2c91c1a8

[lib] Add keys to `sanitization.js:keysWithStringsToBeRedacted`

Tags
None
Referenced Files
F232148: 4d8580.png
Nov 10 2022, 1:50 PM
File Not Attached
Subscribers
None

Description

[lib] Add keys to sanitization.js:keysWithStringsToBeRedacted

Summary:
Specifically to properly redact payload of SET_MESSAGE_STORE_MESSAGES action type.

Added:

  • thread
  • content
  • user
  • uri
  • extras
  • local_id

Test Plan:

  1. Trigger a crash after SET_MESSAGE_STORE_MESSAGES
  2. Download crash report
  3. Check SET_MESSAGE_STORE_MESSAGES payload to make sure things are properly redacted

4d8580.png (1×978 px, 334 KB)

Reviewers: tomek, varun, marcin, rohan, ginsu, O2 Blocking Reviewers, ashoat

Reviewed By: O2 Blocking Reviewers, ashoat

Subscribers: ashoat, abosh

Differential Revision: https://phab.comm.dev/D5586

Details

Provenance
atulAuthored on Nov 10 2022, 1:37 PM
Reviewer
Restricted Owners Package
Differential Revision
D5586: [lib] Add keys to `sanitization.js:keysWithStringsToBeRedacted`
Parents
rCOMMacde9ed66e4e: [landing] added argument to SIWE webview message
Branches
Unknown
Tags
Unknown