HomePhabricator
Diffusion Comm c4391ebe1f85

[native] Make panelSecondaryForeground light mode correspond to dark mode

Tags
None
Referenced Files
F546226: Screenshot 2023-05-19 at 2.18.54 PM.png
May 19 2023, 12:56 PM
File Not Attached
F546225: Screenshot 2023-05-19 at 2.18.40 PM.png
May 19 2023, 12:56 PM
File Not Attached
F546216: Screenshot 2023-05-19 at 2.04.38 PM.png
May 19 2023, 12:56 PM
File Not Attached
F546215: Screenshot 2023-05-19 at 2.04.47 PM.png
May 19 2023, 12:56 PM
File Not Attached
F546214: Screenshot 2023-05-19 at 2.05.43 PM.png
May 19 2023, 12:56 PM
File Not Attached
F546213: Screenshot 2023-05-19 at 2.05.07 PM.png
May 19 2023, 12:56 PM
File Not Attached
Subscribers
None

Description

[native] Make panelSecondaryForeground light mode correspond to dark mode

Summary:
We're using shadesDark80 and shadesDark70 for dark mode, so I figure it made sense to use the corresponding shadesWhite80 and shadesWhite70 for light mode.

I also think this looks better. Note that panelSecondaryForeground is only used in the calendar, as well as the inner tile in ExistingEthereumAccount. Meanwhile, panelSecondaryForegroundBorder is only used for placeholder text in the new registration flow, and the border around a non-selected radio button in RegistrationTile. Screenshots for all three are in the Test Plan.

Depends on D7887

Test Plan:

beforeafter
calendar (secondary foreground)
Screenshot 2023-05-19 at 2.05.07 PM.png (2×1 px, 895 KB)
Screenshot 2023-05-19 at 2.05.43 PM.png (2×1 px, 899 KB)
inner tile (secondary foreground)
Screenshot 2023-05-19 at 2.04.47 PM.png (2×1 px, 831 KB)
Screenshot 2023-05-19 at 2.04.38 PM.png (2×1 px, 831 KB)
RegistrationTile (secondary foreground border)
Screenshot 2023-05-19 at 2.18.40 PM.png (2×1 px, 867 KB)
Screenshot 2023-05-19 at 2.18.54 PM.png (2×1 px, 866 KB)

For RegistrationTile, the secondary foreground border color is used in the non-selected radio button border and the placeholder text.

Note that the registration flow will ONLY support dark mode; the screenshots are shared to give some visual context, but are not real screenshots that will be possible in the app.

Reviewers: ted

Reviewed By: ted

Subscribers: tomek, atul

Differential Revision: https://phab.comm.dev/D7888

Details

Provenance
ashoatAuthored on May 19 2023, 11:06 AM
Reviewer
ted
Differential Revision
D7888: [native] Make panelSecondaryForeground light mode correspond to dark mode
Parents
rCOMM57c179eba9db: [native] Update panelSecondaryForeground to shadesBlack80
Branches
Unknown
Tags
Unknown