HomePhabricator
Diffusion Comm ca9417df6504

[native] Remove background from modal items

Tags
None
Referenced Files
F307060: image.png
Dec 29 2022, 9:26 AM
File Not Attached
F307058: image.png
Dec 29 2022, 9:26 AM
File Not Attached
Subscribers
None

Description

[native] Remove background from modal items

Summary:
Related issue: https://linear.app/comm/issue/ENG-2437/address-feedback-from-design-team-on-light-mode (see discussion in comments)
The background of items in sidebars modal and subchannels modal was beging set to the same value as the modals background in the dark mode, and a different value in the light mode, which resulted in a very weird effect. By removing the
backgroundColor option I'm setting it to be transparent, so now elements have the same background colour as the modal, which is what we want.

This is what used to happen:

image.png (1×512 px, 51 KB)

This is what happens now:

image.png (744×672 px, 67 KB)

Test Plan: Run ios (iPhone 13) and android (Android 12) simulators, checked in dark and light mode that in sidebar and subchannels modals items backgrounds look right.

Reviewers: przemek, tomek, michal

Reviewed By: tomek

Subscribers: ashoat, atul

Differential Revision: https://phab.comm.dev/D6062

Details

Provenance
InkaSokolowskaAuthored on Dec 29 2022, 9:09 AM
Reviewer
tomek
Differential Revision
D6062: [native] Remove background from modal items
Parents
rCOMMe9ba04d76d40: [native] Add subchannels button to drawer items
Branches
Unknown
Tags
Unknown