HomePhabricator
Diffusion Comm ccd926274f68

[services] Backup - Fix terminate callback in pull backup reactor

Description

[services] Backup - Fix terminate callback in pull backup reactor

Summary: We have to check whether the get reactor is initialized in the pull backup reactor before checking its status. The initialization of this reactor happens in the writeResponse method so if we have an error in the initialize method, terminate's going to be called with get reactor uninitialized and that will lead to a crash.

Test Plan: make a request for pulling a backup without passing a backup id (missing any fields would trigger this I think).

Reviewers: palys-swm

Reviewed By: palys-swm

Subscribers: ashoat, palys-swm, Adrian, atul, yayabosh

Differential Revision: https://phab.comm.dev/D4223

Details

Provenance
karolAuthored on Jul 19 2022, 3:15 AM
Reviewer
tomek
Differential Revision
D4223: [services] Backup - Fix terminate callback in pull backup reactor
Parents
rCOMM69b3a66efe71: [keyserver] Fix fetchKnownUserInfos
Branches
Unknown
Tags
Unknown