HomePhabricator
Diffusion Comm f5fdef760d4e

[desktop] Add context menu

Tags
None
Referenced Files
F645099: image.png
Aug 2 2023, 2:39 AM
File Not Attached
F645098: image.png
Aug 2 2023, 2:39 AM
File Not Attached
Subscribers
None

Description

[desktop] Add context menu

Summary:
ENG-4407

Adds a right click context menu to the electron app. Uses electron-context-menu for that, because it comes with some nice defaults and window handling.

The github page readme contains a nice explanation of available options, so if anyone thinks we should change the list I'm open to that.

Adding ashoat as there's a new dependency

Test Plan:
Right click on text and images and check if context menu is displayed:

image.png (254×284 px, 24 KB)

image.png (120×248 px, 22 KB)

I checked if all visibile options work as expected.

On windows it should work the same way, it will just show an additional "Select All" option.

Reviewers: kamil, inka, ashoat

Reviewed By: inka

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D8573

Details

Provenance
Michal Gniadek <michal.gniadek@swmansion.com>Authored on Jul 19 2023, 9:39 AM
Reviewer
inka
Differential Revision
D8573: [desktop] Add context menu
Parents
rCOMM7df79984aa92: [keyserver] Stop sending incorrect macOS rescinds
Branches
Unknown
Tags
Unknown

Event Timeline

Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMMf5fdef760d4e: [desktop] Add context menu (authored by Michal Gniadek <michal.gniadek@swmansion.com>).Aug 2 2023, 2:38 AM