HomePhabricator
Diffusion Comm fdf85ed0dc23

[native] Fix infinite image loader

Tags
None
Referenced Files
F619914: light1.png
Jul 5 2023, 3:02 AM
File Not Attached
F619913: dark1.png
Jul 5 2023, 3:02 AM
File Not Attached
Subscribers
None

Description

[native] Fix infinite image loader

Summary:
https://linear.app/comm/issue/ENG-4271/encrypted-media-load-failures-display-spinners-infinitely-on-native. In addition, upload error
icon has been changed, to match new error icon (and icon available on web).

Screenshots:

dark1.png (956×453 px, 115 KB)

light1.png (956×453 px, 118 KB)

Test Plan:

  1. Change url to local blob service url in lib/facts/blob-service.js
  2. Change useBlobServiceUploads to true in native/input/input-state-container.react.js
  3. Run blob service
  4. To emulate error, disconnect blob service or change result.success to false in native/media/encrypted-image.react.js

Reviewers: bartek, tomek, kamil, inka

Reviewed By: bartek

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D8418

Details

Provenance
patrykAuthored on Jul 3 2023, 6:19 AM
Reviewer
bartek
Differential Revision
D8418: [native] Fix infinite image loader
Parents
rCOMM4dd687a09742: [nix] add emscripten dependency
Branches
Unknown
Tags
Unknown