if the password is wrong we shouldn't display the unknown error text.
Improving the error message is tracked in https://linear.app/comm/issue/ENG-7111/make-grpc-statuses-clearer-in-protocol-error-to-grpc-status-function
Details
Details
- Reviewers
ashoat - Commits
- rCOMMb7b0e9b81b8a: [native] fix regression in error handling
confirmed that the "incorrect username or password" alert displays now when the password is incorrect
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/account/log-in-panel.react.js | ||
|---|---|---|
| 330–331 ↗ | (On Diff #38640) | What do these two separate errors mean, out of curiosity? Is one basically "incorrect password" and the other is "incorrect username"? |
| native/account/log-in-panel.react.js | ||
|---|---|---|
| 330–331 ↗ | (On Diff #38640) | yeah exactly. the first is incorrect username, the second is incorrect password improving the second one, which is too vague IMO, is tracked in the linear task linked in the diff description above |