Page MenuHomePhabricator

Ensure that the same ETH account is used for each signature
ClosedPublic

Authored by marcin on Wed, May 15, 6:36 AM.
Tags
None
Referenced Files
F1786252: D12051.diff
Sat, May 18, 4:24 PM
F1783519: D12051.id40280.diff
Sat, May 18, 11:09 AM
F1783518: D12051.id40279.diff
Sat, May 18, 11:09 AM
F1783517: D12051.id40218.diff
Sat, May 18, 11:09 AM
F1783478: D12051.id.diff
Sat, May 18, 11:09 AM
F1783446: D12051.diff
Sat, May 18, 11:07 AM
Unknown Object (File)
Wed, May 15, 6:42 AM
Subscribers

Details

Summary

Ensure that signature takes no effect if user uses different account than the one they used for social proof generation.

Test Plan
  1. Log in
  2. Switch to different wallet in Rainbow app
  3. Generate backup message with diferent wallet.
  4. Ensure that alert is displayed and backup message generation screen doesn't go away.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

native/account/registration/missing-registration-data/missing-siwe-backup-message.react.js
32 ↗(On Diff #40218)

Please keep all lines to 80 chars. Also the period at the end here is unusual for invariants on this team

41–42 ↗(On Diff #40218)
native/account/registration/siwe-backup-message-creation.react.js
171–172 ↗(On Diff #40218)

Same here

Please address inline comments before landing

This revision is now accepted and ready to land.Wed, May 15, 7:04 AM
  1. Address Ashoat's sugestions.
  2. Rebase before landing
This revision was landed with ongoing or failed builds.Thu, May 16, 3:56 AM
This revision was automatically updated to reflect the committed changes.