Page MenuHomePhabricator
Differential D12051

Ensure that the same ETH account is used for each signature
ClosedPublic
Actions

Authored by marcin on May 15 2024, 6:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 2, 5:57 AM
Unknown Object (File)
Thu, Oct 31, 9:15 PM
Unknown Object (File)
Sat, Oct 26, 5:06 AM
Unknown Object (File)
Sat, Oct 26, 5:06 AM
Unknown Object (File)
Sat, Oct 26, 5:06 AM
Unknown Object (File)
Sat, Oct 26, 5:05 AM
Unknown Object (File)
Sat, Oct 26, 5:01 AM
Unknown Object (File)
Thu, Oct 24, 1:57 PM
View All Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMM16cd530ee676: Ensure that the same ETH account is used for each signature
Summary

Ensure that signature takes no effect if user uses different account than the one they used for social proof generation.

Test Plan
  1. Log in
  2. Switch to different wallet in Rainbow app
  3. Generate backup message with diferent wallet.
  4. Ensure that alert is displayed and backup message generation screen doesn't go away.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.May 15 2024, 6:36 AM
Herald added a subscriber: tomek. · View Herald TranscriptMay 15 2024, 6:36 AM
marcin added a comment.May 15 2024, 6:42 AM

marcin attached a referenced file: F1768247: Simulator Screen Recording - iPhone 15 Pro - 2024-05-15 at 15.41.14.mp4. (Show Details)May 15 2024, 6:42 AM
marcin added 1 blocking reviewer(s): ashoat.
ashoat added inline comments.May 15 2024, 6:51 AM
native/account/registration/missing-registration-data/missing-siwe-backup-message.react.js
32 ↗(On Diff #40218)

Please keep all lines to 80 chars. Also the period at the end here is unusual for invariants on this team

41–42 ↗(On Diff #40218)
native/account/registration/siwe-backup-message-creation.react.js
171–172 ↗(On Diff #40218)

Same here

Harbormaster completed remote builds in B28939: Diff 40218.May 15 2024, 6:53 AM
marcin requested review of this revision.May 15 2024, 6:53 AM
ashoat accepted this revision.May 15 2024, 7:04 AM

Please address inline comments before landing

This revision is now accepted and ready to land.May 15 2024, 7:04 AM
marcin updated this revision to Diff 40279.May 16 2024, 3:44 AM
  1. Address Ashoat's sugestions.
  2. Rebase before landing
This revision was landed with ongoing or failed builds.May 16 2024, 3:56 AM
Closed by commit rCOMM16cd530ee676: Ensure that the same ETH account is used for each signature (authored by marcin). · Explain Why
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM16cd530ee676: Ensure that the same ETH account is used for each signature.
Harbormaster completed remote builds in B28976: Diff 40279.May 16 2024, 4:00 AM

Revision Contents
Changeset List

PathSize
native/
account/
registration/
missing-registration-data/
25 lines
14 lines

Diff 40280

View Options

native/account/registration/missing-registration-data/missing-siwe-backup-message.react.js

Loading...
View Options

native/account/registration/siwe-backup-message-creation.react.js

Loading...