Page MenuHomePhabricator

[native] Only show CommunityDrawerItem for communities
ClosedPublic

Authored by ashoat on May 28 2024, 12:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 10:34 PM
Unknown Object (File)
Tue, Nov 12, 9:02 AM
Unknown Object (File)
Tue, Nov 12, 8:47 AM
Unknown Object (File)
Tue, Nov 12, 8:05 AM
Unknown Object (File)
Tue, Nov 12, 3:22 AM
Unknown Object (File)
Mon, Nov 11, 6:33 AM
Unknown Object (File)
Oct 10 2024, 9:51 PM
Unknown Object (File)
Oct 10 2024, 9:51 PM
Subscribers

Details

Summary

We already do this on web, since there we render a separate React component for community items (CommunityDrawerItemCommunity) than channels (CommunityDrawerItem).

On native we use the same component. We shouldn't be showing any options for channels, but we currently show an option to admins to manage the roles. Roles should only be managed on a per-community basis, so this diff hides the "three dots" button for all channels. This results in a much cleaner look with fewer "three dots" buttons.

Test Plan

Confirm that the "three dots" button only appears for community roots, and not for channels on my local iOS simulator

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.May 29 2024, 2:37 AM

We might want to check if the layout is not affected by this - for example whether channels with long names display correctly

Thanks for calling this out. Here's what it looks like – I think it's probably fine.

Screenshot 2024-05-29 at 1.06.02 PM.png (160×562 px, 16 KB)