This will be used in the next diff so we can sort the communities and ENS-resolved channels within them alphabetically.
I used chatMentionCandidatesObj from the ChatMentionsContext to avoid ENS-resolving all ThreadInfos twice.
Details
Details
I tested the stack as follows:
- I tested both native and web
- I tested both normal communities and GENESIS
- I tested both uppercase and lowercase names
- I made sure the list of channels was the same before and after (only the order changed)
- I edited a name on web and made sure its appearance in the order changed
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/hooks/thread-hooks.js | ||
|---|---|---|
| 16 ↗ | (On Diff #42139) | It feels wrong to use a mention-specific util in a hook that will be used outside the mentioning context. |
| lib/hooks/thread-hooks.js | ||
|---|---|---|
| 16 ↗ | (On Diff #42139) | Yeah, this is weird. Ideally we'd rename useChatMentionContext to have a more general name, but I didn't have time to address that here |