Page MenuHomePhabricator

[lib] Increase timeout for leave_thread
ClosedPublic

Authored by ashoat on Aug 5 2024, 1:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 10:33 AM
Unknown Object (File)
Sun, Nov 10, 3:28 AM
Unknown Object (File)
Sat, Nov 2, 7:36 AM
Unknown Object (File)
Sat, Nov 2, 7:36 AM
Unknown Object (File)
Sat, Nov 2, 7:36 AM
Unknown Object (File)
Sat, Nov 2, 7:16 AM
Unknown Object (File)
Oct 19 2024, 8:24 AM
Unknown Object (File)
Oct 18 2024, 9:44 PM
Subscribers
None

Details

Summary

Noticed that my test user's web client timed out when leaving the Comm community. I think we should increase the timeout here to match the other uses of permissionsAndAuthRelatedRequestTimeout.

Test Plan
  1. Flow
  2. I compared these lines with other ones in the same file (eg. changeThreadMemberRoles) and concluded they were safe

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 5 2024, 1:26 PM
Harbormaster failed remote builds in B30942: Diff 43157!
ashoat requested review of this revision.Aug 5 2024, 2:04 PM

Android build failure is unrelated: ENG-8959

This revision is now accepted and ready to land.Aug 6 2024, 1:31 AM
This revision was landed with ongoing or failed builds.Aug 6 2024, 6:57 AM
This revision was automatically updated to reflect the committed changes.