Paths

Table of Contentst

[lib] Increase timeout for leave_thread
ClosedPublic
Actions

Authored by ashoat on Aug 5 2024, 1:02 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Nov 25 2024, 2:18 PM

	Unknown Object (File)
	Nov 22 2024, 1:17 AM

	Unknown Object (File)
	Nov 10 2024, 10:33 AM

	Unknown Object (File)
	Nov 10 2024, 3:28 AM

	Unknown Object (File)
	Nov 2 2024, 7:36 AM

	Unknown Object (File)
	Nov 2 2024, 7:36 AM

	Unknown Object (File)
	Nov 2 2024, 7:36 AM

	Unknown Object (File)
	Nov 2 2024, 7:16 AM

View All 44 Files

Subscribers

None

Details

Reviewers

tomek

Commits

rCOMMb9e0684e4a21: [lib] Increase timeout for leave_thread

Summary

Noticed that my test user's web client timed out when leaving the Comm community. I think we should increase the timeout here to match the other uses of permissionsAndAuthRelatedRequestTimeout.

Test Plan

Flow
I compared these lines with other ones in the same file (eg. changeThreadMemberRoles) and concluded they were safe

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Aug 5 2024, 1:02 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 5 2024, 1:26 PM

Harbormaster failed remote builds in B30942: Diff 43157!

Android build failure is unrelated: ENG-8959

tomek accepted this revision.Aug 6 2024, 1:31 AM

This revision is now accepted and ready to land.Aug 6 2024, 1:31 AM

This revision was landed with ongoing or failed builds.Aug 6 2024, 6:57 AM

Closed by commit rCOMMb9e0684e4a21: [lib] Increase timeout for leave_thread (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMb9e0684e4a21: [lib] Increase timeout for leave_thread.

Revision Contents
Changeset List

Path

Size

lib/

actions/

thread-actions.js

9 lines

Diff 43183

View Options

lib/actions/thread-actions.js

[lib] Increase timeout for leave_threadClosedPublicActions