[lib] Increase timeout for leave_thread
ClosedPublic
Actions

Authored by ashoat on Aug 5 2024, 1:02 PM.

Details

Reviewers

tomek

Commits

rCOMMb9e0684e4a21: [lib] Increase timeout for leave_thread

Summary

Noticed that my test user's web client timed out when leaving the Comm community. I think we should increase the timeout here to match the other uses of permissionsAndAuthRelatedRequestTimeout.

Test Plan

Flow
I compared these lines with other ones in the same file (eg. changeThreadMemberRoles) and concluded they were safe

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/pin

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Aug 5 2024, 1:02 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 5 2024, 1:26 PM

Harbormaster failed remote builds in B30942: Diff 43157!

Android build failure is unrelated: ENG-8959

tomek accepted this revision.Aug 6 2024, 1:31 AM

This revision is now accepted and ready to land.Aug 6 2024, 1:31 AM

This revision was landed with ongoing or failed builds.Aug 6 2024, 6:57 AM

Closed by commit rCOMMb9e0684e4a21: [lib] Increase timeout for leave_thread (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMb9e0684e4a21: [lib] Increase timeout for leave_thread.

Revision Contents
Changeset List

Path

Size

lib/

actions/

thread-actions.js

9 lines

Diff 43157

View Options

lib/actions/thread-actions.js

	Show All 33 Lines
	function useCreateDesktopPushSubscription() {			function useCreateDesktopPushSubscription() {
	const dispatchActionPromise = useDispatchActionPromise();			const dispatchActionPromise = useDispatchActionPromise();
	const callSetDeviceToken = useSetDeviceTokenFanout();			const callSetDeviceToken = useSetDeviceTokenFanout();
	const staffCanSee = useStaffCanSee();			const staffCanSee = useStaffCanSee();

	React.useEffect(			React.useEffect(
	() =>			() =>
	electron?.onDeviceTokenRegistered?.((token: ?string) => {			electron?.onDeviceTokenRegistered?.((token: ?string) => {
	dispatchActionPromise(			void dispatchActionPromise(
	setDeviceTokenActionTypes,			setDeviceTokenActionTypes,
	callSetDeviceToken(token),			callSetDeviceToken(token),
	);			);
	}),			}),
	[callSetDeviceToken, dispatchActionPromise],			[callSetDeviceToken, dispatchActionPromise],
	);			);

	React.useEffect(() => {			React.useEffect(() => {
	▲ Show 20 Lines • Show All 181 Lines • Show Last 20 Lines

[lib] Increase timeout for leave_threadClosedPublicActions