Page MenuHomePhabricator
Differential D12990

[lib] Increase timeout for leave_thread
ClosedPublic
Actions

Authored by ashoat on Aug 5 2024, 1:02 PM.
Tags
None
Referenced Files
F3342341: D12990.diff
Fri, Nov 22, 1:17 AM
Unknown Object (File)
Sun, Nov 10, 10:33 AM
Unknown Object (File)
Sun, Nov 10, 3:28 AM
Unknown Object (File)
Sat, Nov 2, 7:36 AM
Unknown Object (File)
Sat, Nov 2, 7:36 AM
Unknown Object (File)
Sat, Nov 2, 7:36 AM
Unknown Object (File)
Sat, Nov 2, 7:16 AM
Unknown Object (File)
Oct 19 2024, 8:24 AM
View All 43 Files
Subscribers
None

Details

Reviewers
tomek
Commits
rCOMMb9e0684e4a21: [lib] Increase timeout for leave_thread
Summary

Noticed that my test user's web client timed out when leaving the Comm community. I think we should increase the timeout here to match the other uses of permissionsAndAuthRelatedRequestTimeout.

Test Plan
  1. Flow
  2. I compared these lines with other ones in the same file (eg. changeThreadMemberRoles) and concluded they were safe

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/pin
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Aug 5 2024, 1:02 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Aug 5 2024, 1:26 PM
Harbormaster failed remote builds in B30942: Diff 43157!
ashoat requested review of this revision.Aug 5 2024, 2:04 PM

Android build failure is unrelated: ENG-8959

tomek accepted this revision.Aug 6 2024, 1:31 AM
This revision is now accepted and ready to land.Aug 6 2024, 1:31 AM
This revision was landed with ongoing or failed builds.Aug 6 2024, 6:57 AM
Closed by commit rCOMMb9e0684e4a21: [lib] Increase timeout for leave_thread (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMb9e0684e4a21: [lib] Increase timeout for leave_thread.

Revision Contents
Changeset List

PathSize
lib/
actions/
9 lines

Diff 43157

View Options

lib/actions/thread-actions.js

Loading...