Page MenuHomePhabricator

[web] Fix modal styles
ClosedPublic

Authored by inka on Aug 28 2024, 3:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 9:41 PM
Unknown Object (File)
Wed, Nov 6, 9:41 PM
Unknown Object (File)
Wed, Nov 6, 9:41 PM
Unknown Object (File)
Wed, Nov 6, 9:41 PM
Unknown Object (File)
Oct 6 2024, 8:13 PM
Unknown Object (File)
Oct 6 2024, 8:13 PM
Unknown Object (File)
Oct 6 2024, 8:13 PM
Unknown Object (File)
Oct 6 2024, 7:28 PM
Subscribers
None

Details

Summary

issue: ENG-8679
The issue was that the pinned messages modal div was not scrollable, but fixing this revealed another issue: contents of Modal were wrapped by modalContentContainer which allowed its content to extend it.

Test Plan

Checked ALL places where Modal component is used. Checked that after these changes they all work correctly. Here are modals that got changed:

Here is before and after for the search component (using prod and dev):

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable