Page MenuHomePhabricator
Differential D13277

[lib] modify queryTimeout
ClosedPublic
Actions

Authored by varun on Tue, Sep 10, 1:00 PM.
Tags
None
Referenced Files
F2753930: D13277.id44013.diff
Wed, Sep 18, 6:27 PM
Unknown Object (File)
Wed, Sep 18, 6:19 PM
Unknown Object (File)
Tue, Sep 17, 2:47 PM
Unknown Object (File)
Tue, Sep 17, 9:25 AM
Unknown Object (File)
Tue, Sep 17, 5:12 AM
Unknown Object (File)
Mon, Sep 16, 10:34 PM
Unknown Object (File)
Sun, Sep 15, 12:32 PM
Unknown Object (File)
Sat, Sep 14, 8:58 AM
View All 12 Files
Subscribers
ashoat
tomek

Details

Reviewers
ashoat
Commits
rCOMM2bf0928d0074: [lib] modify queryTimeout
Summary

@ashoat was unable to see usernames on web after logging in following the CSAT launch. he's seen this on native, too. we suspect that the timeout is too short.

more context here: https://linear.app/comm/issue/ENG-9227/ashoat-didnt-see-usernames-on-web-after-logging-in-following-csat

Test Plan

modified identity RPC to sleep for 15 seconds and the previous 10 second timeout was triggered. after changing the timeout duration, I was able to get a response from identity

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Tue, Sep 10, 1:00 PM
Herald added a subscriber: tomek. · View Herald TranscriptTue, Sep 10, 1:00 PM
ashoat published this revision for review.Tue, Sep 10, 1:09 PM
ashoat accepted this revision.
This revision is now accepted and ready to land.Tue, Sep 10, 1:10 PM
Harbormaster completed remote builds in B31512: Diff 44013.Tue, Sep 10, 1:17 PM
Closed by commit rCOMM2bf0928d0074: [lib] modify queryTimeout (authored by varun). · Explain WhyTue, Sep 10, 4:07 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM2bf0928d0074: [lib] modify queryTimeout.

Revision Contents
Changeset List

PathSize
lib/
components/
2 lines

Diff 44017

View Options

lib/components/user-identity-cache.react.js

Loading...