[lib] Include targetUserID in DMUpdateRelationshipOperation
ClosedPublic
Actions

Authored by ashoat on Sep 23 2024, 10:20 PM.

Details

Reviewers

tomek

Commits

rCOMM625c27ad811e: [lib] Include targetUserID in DMUpdateRelationshipOperation

Summary

This was an oversight from D13392. We need to process the same DM op on both the sender and recipient, so we should include a targetUserID in the op so it's clear who the target is. Otherwise, the sender sees "you sent a friend request to you".

Depends on D13432

Test Plan

Confirm the sender sees the proper robotext after this change

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Sep 23 2024, 10:20 PM

ashoat added a child revision: D13434: [lib] Correct creatorID in DMOp validators to tUserID.Sep 23 2024, 10:25 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 23 2024, 10:33 PM

Harbormaster failed remote builds in B31790: Diff 44456!

Prettier

Harbormaster completed remote builds in B31801: Diff 44467.Sep 23 2024, 11:29 PM

ashoat requested review of this revision.Sep 23 2024, 11:29 PM

tomek accepted this revision.Sep 24 2024, 1:44 AM

This revision is now accepted and ready to land.Sep 24 2024, 1:44 AM

Closed by commit rCOMM625c27ad811e: [lib] Include targetUserID in DMUpdateRelationshipOperation (authored by ashoat). · Explain WhySep 24 2024, 3:04 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM625c27ad811e: [lib] Include targetUserID in DMUpdateRelationshipOperation.

Revision Contents
Changeset List

Path

Size

lib/

shared/

dm-ops/

update-relationship-spec.js

14 lines

types/

dm-ops.js

2 lines

Diff 44456

View Options

lib/shared/dm-ops/update-relationship-spec.js