[lib] fix changing thread description on native for thick threads
ClosedPublic
Actions

Authored by kamil on Tue, Sep 24, 5:35 AM.

Details

Reviewers

tomek
ashoat

Commits

rCOMMecb034ad0ed1: [lib] fix changing thread description on native for thick threads

Summary

ENG-9316.

The description is a nullable field (link), so whenever clicking editing button for not edited or not set description here it causes changing value from undefined to undefined and a result nothing changes. We're not entering this branch which renders TextInput.

For thin threads, it works only because for some reason keyserver is replacing undefined description with an empty string here.

The alternative solution is to create a thick thread with an empty string as a description (instead of undefined), but I don't like this because types still allow for descryption to be nullable so this bug might be caused again in the future.

Test Plan

Change thread settings on native works for thin and thick threads.
Notifs works.
Changing the description to the same value is a no-op.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Tue, Sep 24, 5:35 AM

kamil held this revision as a draft.

kamil published this revision for review.Tue, Sep 24, 5:37 AM

kamil edited the summary of this revision. (Show Details)

kamil edited the test plan for this revision. (Show Details)

tomek accepted this revision.Tue, Sep 24, 5:39 AM

This revision is now accepted and ready to land.Tue, Sep 24, 5:39 AM

tomek added inline comments.Tue, Sep 24, 5:40 AM

native/chat/settings/thread-settings-description.react.js
231 ↗	(On Diff #44482)	Wondering if this won't result in sending operations that replace `null` with `''` - after clinking the input and accepting changes.

add empty string as default description

Harbormaster completed remote builds in B31814: Diff 44482.Tue, Sep 24, 5:52 AM

kamil added inline comments.Tue, Sep 24, 5:53 AM

native/chat/settings/thread-settings-description.react.js
231 ↗	(On Diff #44482)	As we disccussed offline - this causes an empty update (without robotext), so avoid that we're gonna match what the keyserver is doing and fill not not-defined description with an empty string in the thread creation spec.