Paths

Table of Contentst

[lib] Don't run InitialStateSharingHandler while logged out
ClosedPublic
Actions

Authored by ashoat on Sep 24 2024, 7:34 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Dec 5, 9:06 PM

	Unknown Object (File)
	Thu, Dec 5, 9:03 PM

	Unknown Object (File)
	Thu, Dec 5, 9:03 PM

	Unknown Object (File)
	Thu, Dec 5, 8:44 PM

	Unknown Object (File)
	Nov 17 2024, 10:51 PM

	Unknown Object (File)
	Nov 17 2024, 6:33 PM

	Unknown Object (File)
	Nov 1 2024, 2:49 PM

	Unknown Object (File)
	Oct 30 2024, 4:47 PM

View All 40 Files

Subscribers

None

Details

Reviewers

tomek
kamil

Commits

rCOMMe4f4c657d346: [lib] Don't run InitialStateSharingHandler while logged out

Summary

This addresses ENG-9372.

The log spam is occurring because of the getAuthMetadata call here. We can avoid it by only calling getAuthMetadata while logged in.

Test Plan

Confirm that the log spam no longer appears while logged out

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Sep 24 2024, 7:34 PM

Harbormaster completed remote builds in B31836: Diff 44522.Sep 24 2024, 7:51 PM

ashoat requested review of this revision.Sep 24 2024, 7:51 PM

kamil accepted this revision.Sep 25 2024, 12:02 AM

This revision is now accepted and ready to land.Sep 25 2024, 12:02 AM

Closed by commit rCOMMe4f4c657d346: [lib] Don't run InitialStateSharingHandler while logged out (authored by ashoat). · Explain WhySep 25 2024, 5:44 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMe4f4c657d346: [lib] Don't run InitialStateSharingHandler while logged out.

Revision Contents
Changeset List

Path

Size

lib/

handlers/

initial-state-sharing-handler.react.js

8 lines

Diff 44530

View Options

lib/handlers/initial-state-sharing-handler.react.js

[lib] Don't run InitialStateSharingHandler while logged outClosedPublicActions