Page MenuHomePhabricator

[lib][keyserver][native] Stop sending passwords to authoritative keyserver on registration
ClosedPublic

Authored by ashoat on Oct 28 2024, 1:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 7:56 PM
Unknown Object (File)
Sun, Dec 15, 7:56 PM
Unknown Object (File)
Sun, Dec 15, 7:55 PM
Unknown Object (File)
Sun, Dec 15, 7:50 PM
Unknown Object (File)
Mon, Dec 2, 12:47 AM
Unknown Object (File)
Fri, Nov 29, 8:01 AM
Unknown Object (File)
Fri, Nov 29, 7:43 AM
Unknown Object (File)
Nov 24 2024, 8:41 PM
Subscribers

Details

Summary

Context for why we want to revert this is in D12641. Linear task: ENG-8698

This reverts commit 51a51ba64cc988a189e843d1165a8c77ecad578f.

It's not a perfect revert, since we need to preserve the field in keyserverAuthRequestInputValidator for old clients.

To keep the field in the validator, I had to split KeyserverAuthRequest into two types, one for keyserver and one for clients.

Test Plan

I ran through the registration flow in my local environment and made sure it still works. I confirmed that the hash column in the users table in MariaDB is NULL

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable