[native] Address feedback from D14017
ClosedPublic
Actions

Authored by ashoat on Nov 30 2024, 8:32 AM.

Tags

None

Referenced Files

	F3744027: D14068.id46167.diff
	Thu, Jan 9, 2:56 PM

	F3744026: D14068.id46157.diff
	Thu, Jan 9, 2:56 PM

	F3743996: D14068.diff
	Thu, Jan 9, 2:55 PM

	Unknown Object (File)
	Wed, Jan 8, 3:43 AM

	Unknown Object (File)
	Wed, Jan 8, 2:53 AM

	Unknown Object (File)
	Mon, Jan 6, 4:53 PM

	Unknown Object (File)
	Fri, Jan 3, 7:24 AM

	Unknown Object (File)
	Fri, Jan 3, 6:58 AM

View All 28 Files

Subscribers

angelika

Details

Reviewers

angelika
tomek

Commits

rCOMM84186ad96c27: [native] Address feedback from D14017

Summary

My feedback was not addressed.

Test Plan

I have not tested this. It's ultimately @angelika's responsibility to test her work, and it's unusual that a reviewer would be submitting a diff to address their own feedback

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Nov 30 2024, 8:32 AM

ashoat mentioned this in D14017: [native] Migrate componentDidUpdate() in ChatInputBar to function component.Nov 30 2024, 8:40 AM

Harbormaster completed remote builds in B32901: Diff 46157.Nov 30 2024, 8:50 AM

ashoat requested review of this revision.Nov 30 2024, 8:50 AM

angelika accepted this revision.Dec 2 2024, 3:37 AM

This revision is now accepted and ready to land.Dec 2 2024, 3:37 AM

Closed by commit rCOMM84186ad96c27: [native] Address feedback from D14017 (authored by ashoat). · Explain WhyDec 2 2024, 9:02 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM84186ad96c27: [native] Address feedback from D14017.

Revision Contents
Changeset List

Path

Size

native/

chat/

chat-input-bar.react.js

2 lines

Diff 46167

View Options

native/chat/chat-input-bar.react.js

[native] Address feedback from D14017ClosedPublicActions