[native] Address feedback from D14017
ClosedPublic
Actions

Authored by ashoat on Sat, Nov 30, 8:32 AM.

Details

Reviewers

angelika
tomek

Commits

rCOMM84186ad96c27: [native] Address feedback from D14017

Summary

My feedback was not addressed.

Test Plan

I have not tested this. It's ultimately @angelika's responsibility to test her work, and it's unusual that a reviewer would be submitting a diff to address their own feedback

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Sat, Nov 30, 8:32 AM

ashoat mentioned this in D14017: [native] Migrate componentDidUpdate() in ChatInputBar to function component.Sat, Nov 30, 8:40 AM

Harbormaster completed remote builds in B32901: Diff 46157.Sat, Nov 30, 8:50 AM

ashoat requested review of this revision.Sat, Nov 30, 8:50 AM

angelika accepted this revision.Mon, Dec 2, 3:37 AM

This revision is now accepted and ready to land.Mon, Dec 2, 3:37 AM

Closed by commit rCOMM84186ad96c27: [native] Address feedback from D14017 (authored by ashoat). · Explain WhyMon, Dec 2, 9:02 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM84186ad96c27: [native] Address feedback from D14017.

Revision Contents
Changeset List

Path

Size

native/

chat/

chat-input-bar.react.js

2 lines

Diff 46167

View Options

native/chat/chat-input-bar.react.js

[native] Address feedback from D14017ClosedPublicActions