Page MenuHomePhabricator

[native] Address feedback from D14017
ClosedPublic

Authored by ashoat on Nov 30 2024, 8:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 28, 3:34 AM
Unknown Object (File)
Fri, Mar 14, 3:47 AM
Unknown Object (File)
Mar 3 2025, 1:10 PM
Unknown Object (File)
Jan 11 2025, 7:28 AM
Unknown Object (File)
Jan 9 2025, 2:56 PM
Unknown Object (File)
Jan 9 2025, 2:56 PM
Unknown Object (File)
Jan 9 2025, 2:55 PM
Unknown Object (File)
Jan 8 2025, 3:43 AM
Subscribers

Details

Summary

My feedback was not addressed.

Test Plan

I have not tested this. It's ultimately @angelika's responsibility to test her work, and it's unusual that a reviewer would be submitting a diff to address their own feedback

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable