[lib] Always include an extra item in getCandidateSidebarItemsForThreadList
ClosedPublic
Actions

Authored by ashoat on Thu, Dec 19, 6:22 AM.

Details

Reviewers

tomek
angelika

Commits

rCOMM172f8c434b96: [lib] Always include an extra item in getCandidateSidebarItemsForThreadList

Summary

We need the extra item to determine whether to show the "See more..." item. Currently there's a bug where it is omitted when it should be displayed.

Test Plan

I tested in my local environment by creating a bunch of threads and confirming that "See more..." would appear on a web client. Tried from two user accounts, one where it was read and one where it was unread.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Thu, Dec 19, 6:22 AM

Harbormaster completed remote builds in B33185: Diff 46582.Thu, Dec 19, 6:40 AM

ashoat requested review of this revision.Thu, Dec 19, 6:40 AM

tomek accepted this revision.Fri, Dec 20, 3:29 AM

This revision is now accepted and ready to land.Fri, Dec 20, 3:29 AM

Closed by commit rCOMM172f8c434b96: [lib] Always include an extra item in getCandidateSidebarItemsForThreadList (authored by ashoat). · Explain WhyFri, Dec 20, 12:52 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM172f8c434b96: [lib] Always include an extra item in getCandidateSidebarItemsForThreadList.

Revision Contents
Changeset List

Path

Size

lib/

shared/

sidebar-item-utils.js

16 lines

Diff 46595

View Options

lib/shared/sidebar-item-utils.js

[lib] Always include an extra item in getCandidateSidebarItemsForThreadListClosedPublicActions