Paths

Table of Contentst

Differential D14839

[keyserver] Don't crash in socket on responseTo = 0
ClosedPublic
Actions

Authored by ashoat on Jun 12 2025, 3:51 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Commits

rCOMM41c725083337: [keyserver] Don't crash in socket on responseTo = 0

Summary

The id here can be 0, which would cause a crash. We should be more specific in this invariant.

Test Plan

Careful code inspection

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Jun 12 2025, 3:51 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 12 2025, 3:51 PM

Harbormaster completed remote builds in B34411: Diff 48498.Jun 12 2025, 4:10 PM

ashoat requested review of this revision.Jun 12 2025, 4:10 PM

bartek accepted this revision.Jun 14 2025, 9:31 AM

This revision is now accepted and ready to land.Jun 14 2025, 9:31 AM

Closed by commit rCOMM41c725083337: [keyserver] Don't crash in socket on responseTo = 0. · Explain WhyJun 15 2025, 3:46 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM41c725083337: [keyserver] Don't crash in socket on responseTo = 0.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

socket/

5 lines

Diff 48499

keyserver/src/socket/socket.js

Loading...