Differential D15410

[lib] Add an option to refresh a thread
ClosedPublic
Actions

Authored by tomek on Oct 2 2025, 1:15 PM.

Details

Reviewers

kamil

Commits

rCOMMb9a0b5392274: [lib] Add an option to refresh a thread

Summary

On both platforms, add an option to refresh a Farcaster thread

https://linear.app/comm/issue/ENG-11348/add-option-to-refresh-farcaster-conversations

Screenshot 2025-10-02 at 15.20.05.png (750×1 px, 55 KB)

Simulator Screenshot - iPhone 16 - 2025-10-02 at 15.19.01.png (2×1 px, 212 KB)

Test Plan

Checked if refreshing works by updating a name on Farcaster and clicking the button in Comm. Checked if the buttons are displayed only for Farcaster. Also checked if it isn't possible to click the button during the refresh.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Oct 2 2025, 1:15 PM

Herald added a subscriber: ashoat. · View Herald TranscriptOct 2 2025, 1:15 PM

tomek edited the summary of this revision. (Show Details)Oct 2 2025, 1:20 PM

tomek edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B35855: Diff 50504.Oct 2 2025, 1:33 PM

tomek requested review of this revision.Oct 2 2025, 1:33 PM

kamil accepted this revision.Oct 3 2025, 11:03 AM

kamil added inline comments.

native/chat/settings/thread-settings-refresh.react.js
72 ↗	(On Diff #50504)	I think we have a rule not to use ternary inside JSX

This revision is now accepted and ready to land.Oct 3 2025, 11:03 AM

ashoat added inline comments.Oct 3 2025, 11:45 AM

native/chat/settings/thread-settings-refresh.react.js
72 ↗	(On Diff #50504)	I think this case is fine: https://www.notion.so/commapp/Use-ternary-conditionals-sparingly-f4ba44a10259403592a1d15440a9847e?source=copy_link