Cache the results and avoid the Farcaster message from growing too much - if we move calling to the end, we could collect a huge array or raw Farcaster messages.
https://linear.app/comm/issue/ENG-11459/farcaster-dc-sync-is-slow-after-7k-messages
Details
Details
- Reviewers
kamil - Commits
- rCOMM3dc12f5e6103: [lib] Cache the FIDs while fetching messages
Sync and check if the data is shown.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/shared/farcaster/farcaster-hooks.js | ||
|---|---|---|
| 778 ↗ | (On Diff #50679) | I don't think this is a good idea to store it in memory here. I would rather cache f`cUserInfos` top level to make sure we're not calling Identity multiple times for the same users |
Comment Actions
Cache the results instead of moving the call to the end. This should perform well and avoids Farcaster message growing too big.
| lib/shared/farcaster/farcaster-hooks.js | ||
|---|---|---|
| 866–872 ↗ | (On Diff #50682) | One more thing to optimize, you can remove this chunk and just pass identityCache to convertFarcasterMessageToCommMessages |