Details
Integrated this into session logic and tested as described in here (what I was testing and patch to allow using it).
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Publishing to land it and make sure it builds and passes App Store review. Switching API to vodozemac is going to be introduced later, after implementing X3DH support
| native/cpp/CommonCpp/CryptoTools/CryptoModule.h | ||
|---|---|---|
| 13–17 ↗ | (On Diff #50839) | |
| native/native_rust_library/Cargo.toml | ||
| 24 ↗ | (On Diff #50839) | Using my fork because it avoids session unpickling due to the usage of prekeys, @ashoat, can you create a fork in the Comm organization so I can open PRs there and properly reference vodozemac? |
| native/native_rust_library/src/lib.rs | ||
| 570–600 ↗ | (On Diff #50839) | |
| native/native_rust_library/src/session.rs | ||
| 93–97 ↗ | (On Diff #50839) | Here we should use only errors that say something about problems with unpickling, but we can't do it because the module is private. I am going to update this while working on X3DH |
| scripts/build-rust-vodozemac-bindings.sh | ||
| 1–51 ↗ | (On Diff #50839) | similar to build-rust-native-library.sh |
| native/cpp/CommonCpp/CryptoTools/CryptoModule.h | ||
|---|---|---|
| 13–17 ↗ | (On Diff #50839) | What's the main reason to avoid using a "monotholic" lib.rs.h in all cases? Are we trying to avoid it for targets such as the iOS NSE and web? |
| native/ios/Comm.xcodeproj/project.pbxproj | ||
| 2050–2185 ↗ | (On Diff #50839) | What's leading to the changes here, and elsewhere in this file? |
| native/native_rust_library/Cargo.toml | ||
| 24 ↗ | (On Diff #50839) | Done! |
| native/native_rust_library/src/session.rs | ||
| 1 ↗ | (On Diff #50839) | We should find a way to avoid copy-paste for this file |
- remove obsolete header search paths
- use symlink in session.rs
- reference lib.rs files
- update repo source for vodozemac
| native/cpp/CommonCpp/CryptoTools/CryptoModule.h | ||
|---|---|---|
| 13–17 ↗ | (On Diff #50839) | Monotholic lib.rs.h is specific to native_rust_library. Without using ifdefs here:
|
| native/ios/Comm.xcodeproj/project.pbxproj | ||
| 2050–2185 ↗ | (On Diff #50839) | I removed additional changes and left only the vodozemac_bindings header addition |
| native/native_rust_library/Cargo.toml | ||
| 24 ↗ | (On Diff #50839) | Updated repo link |
| native/native_rust_library/src/session.rs | ||
| 1 ↗ | (On Diff #50839) | created symlink |