Differential D15544

[native][lib] remove feature flag service client code
ClosedPublic
Actions

Authored by kamil on Mon, Nov 17, 10:12 AM.

Details

Reviewers

ashoat

Commits

rCOMM61113c608df5: [native][lib] remove feature flag service client code

Summary

ENG-11543.

As part of ENG-11521 I shut down Feature Flag service because it is not used at all, we should also remove client code to make it cleaner and avoid network calls.

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Mon, Nov 17, 10:12 AM

kamil held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptMon, Nov 17, 10:12 AM

Harbormaster failed remote builds in B36055: Diff 50842!Mon, Nov 17, 10:17 AM

kamil published this revision for review.Mon, Nov 17, 11:04 AM

ashoat accepted this revision.Mon, Nov 17, 12:54 PM

ashoat added inline comments.

native/utils/crash-utils.js
17 ↗	(On Diff #50842)	There’s an argument for keeping this line, but I don’t think it matters very much

This revision is now accepted and ready to land.Mon, Nov 17, 12:54 PM

kamil added inline comments.Mon, Nov 17, 1:20 PM

native/utils/crash-utils.js
17 ↗	(On Diff #50842)	I was considering that too, but because we never stored any significant data, I decided to just remove this line

This revision was landed with ongoing or failed builds.Mon, Nov 17, 1:25 PM

Closed by commit rCOMM61113c608df5: [native][lib] remove feature flag service client code. · Explain Why

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM61113c608df5: [native][lib] remove feature flag service client code.

Revision Contents
Changeset List

Path

Size

lib/

facts/

feature-flags.js

utils/

feature-flags-utils.js

native/

components/

feature-flags-provider.react.js

root.react.js

123 lines

utils/

crash-utils.js

2 lines

Diff 50844

View Options

lib/facts/feature-flags.js

View Options

lib/utils/feature-flags-utils.js

View Options

native/components/feature-flags-provider.react.js

View Options

native/root.react.js

View Options

native/utils/crash-utils.js

[native][lib] remove feature flag service client codeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50844

lib/facts/feature-flags.js

lib/utils/feature-flags-utils.js

native/components/feature-flags-provider.react.js

native/root.react.js

native/utils/crash-utils.js

[native][lib] remove feature flag service client code
ClosedPublic
Actions

Revision Contents
Changeset List