[web] Fix multimedia `onRemove` event propagation
ClosedPublic
Actions

Authored by • jacek on Jun 3 2022, 3:53 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 2, 2:33 PM

	Unknown Object (File)
	Mon, Oct 21, 12:32 PM

	Unknown Object (File)
	Wed, Oct 16, 8:43 AM

	Unknown Object (File)
	Wed, Oct 16, 8:43 AM

	Unknown Object (File)
	Wed, Oct 16, 8:43 AM

	Unknown Object (File)
	Sat, Oct 12, 7:50 PM

	Unknown Object (File)
	Oct 7 2024, 10:14 PM

	Unknown Object (File)
	Oct 7 2024, 10:14 PM

Subscribers

Details

Reviewers

tomek
atul

Commits

rCOMM5e7526cca2b4: [web] Fix multimedia `onRemove` event propagation

Summary

Fix for multimedia remove issue: https://linear.app/comm/issue/ENG-1224/uploaded-media-are-displayed-in-fullscreen-modal-when-trying-to-remove

Test Plan

Try to upload and remove that multimedia on web. It should be removed without being opened.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jacek created this revision.Jun 3 2022, 3:53 AM

Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptJun 3 2022, 3:53 AM

Harbormaster completed remote builds in B9617: Diff 13329.Jun 3 2022, 4:00 AM

• jacek requested review of this revision.Jun 3 2022, 4:00 AM

tomek accepted this revision.Jun 3 2022, 4:45 AM

This revision is now accepted and ready to land.Jun 3 2022, 4:45 AM

Closed by commit rCOMM5e7526cca2b4: [web] Fix multimedia `onRemove` event propagation (authored by • jacek). · Explain WhyJun 7 2022, 2:50 AM

This revision was automatically updated to reflect the committed changes.

• jacek added a commit: rCOMM5e7526cca2b4: [web] Fix multimedia `onRemove` event propagation.

Revision Contents
Changeset List

Path

Size

web/

media/

multimedia.react.js

3 lines

Diff 13372

View Options

web/media/multimedia.react.js

[web] Fix multimedia `onRemove` event propagationClosedPublicActions