Page MenuHomePhabricator
Differential D4280

[web] Remove last border from My Account page
ClosedPublic
Actions

Authored by • abosh on Jun 15 2022, 12:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 24 2024, 10:55 PM
Unknown Object (File)
Nov 24 2024, 10:55 PM
Unknown Object (File)
Nov 24 2024, 10:55 PM
Unknown Object (File)
Nov 24 2024, 10:55 PM
Unknown Object (File)
Nov 23 2024, 1:05 PM
Unknown Object (File)
Nov 23 2024, 10:16 AM
Unknown Object (File)
Nov 23 2024, 7:43 AM
Unknown Object (File)
Nov 3 2024, 3:40 PM
View All Files
Subscribers
• adrian
ashoat

Details

Reviewers
atul
tomek
Commits
rCOMMfc388e2669a4: [web] Remove last border from My Account page
Summary

This doesn't match the Figma designs, but discussion on this Linear issue here.

The last border on the My Account page should be removed since there is no border on the top (above Logged in as …).

Before:

image.png (2×1 px, 109 KB)

After:

image.png (2×2 px, 143 KB)

Test Plan

Looks as expected on Safari/Chrome.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• abosh created this revision.Jun 15 2022, 12:01 PM
Herald added subscribers: • adrian, ashoat. · View Herald TranscriptJun 15 2022, 12:01 PM
• abosh edited the summary of this revision. (Show Details)Jun 15 2022, 12:02 PM
• abosh edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B9776: Diff 13532.Jun 15 2022, 12:06 PM
• abosh requested review of this revision.Jun 15 2022, 12:06 PM
• abosh edited the summary of this revision. (Show Details)Jun 15 2022, 1:35 PM
atul accepted this revision.Jun 17 2022, 11:06 AM

(personally think that we should have a border on the top and on the bottom to "frame" things cleanly)

This revision is now accepted and ready to land.Jun 17 2022, 11:06 AM
tomek accepted this revision.Jun 20 2022, 1:00 AM
tomek added inline comments.
web/settings/account-settings.css
17–28 ↗(On Diff #13532)

Maybe it's a better idea to not set a property for the last child, instead of setting and removing it?

Closed by commit rCOMMfc388e2669a4: [web] Remove last border from My Account page (authored by • abosh). · Explain WhyJun 21 2022, 8:19 AM
This revision was automatically updated to reflect the committed changes.
• abosh marked an inline comment as done.
• abosh added a commit: rCOMMfc388e2669a4: [web] Remove last border from My Account page.
• abosh added inline comments.Jun 21 2022, 8:19 AM
web/settings/account-settings.css
17–28 ↗(On Diff #13532)

Incorporating this change (it also looks cleaner), but can I get some clarification as to why using last-child is worse (style-wise or otherwise) than using :not(:last-child)?

Revision Contents
Changeset List

PathSize
web/
settings/
5 lines

Diff 13632

View Options

web/settings/account-settings.css

Loading...