Page MenuHomePhabricator

[landing] Define `--font-stack` for `landing`
AbandonedPublic

Authored by abosh on Jun 24 2022, 12:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 1:57 PM
Unknown Object (File)
Nov 2 2024, 2:21 PM
Unknown Object (File)
Nov 2 2024, 2:21 PM
Unknown Object (File)
Nov 2 2024, 2:17 PM
Unknown Object (File)
Oct 24 2024, 10:51 PM
Unknown Object (File)
Oct 7 2024, 2:26 PM
Unknown Object (File)
Oct 6 2024, 9:36 AM
Unknown Object (File)
Sep 18 2024, 12:55 PM
Subscribers

Details

Reviewers
atul
tomek
Summary

Relevant Linear issue with full context here. Defined new --font-stack global CSS variable using the :root pseudo-class and replaced all instances of the same font usages throughout landing ('IBM Plex Sans', sans-serif).

Read more about CSS global variables.

Test Plan

Made sure everything on landing looked the same before and after the variable was introduced. So, this included the header, footer, subscription form, read docs button, and info blocks.

Diff Detail

Repository
rCOMM Comm
Branch
fontstack (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Should we rename --font-stack to --sans-serif? We can then create global --monospace, --serif, etc as well.

This revision is now accepted and ready to land.Jun 24 2022, 12:51 PM

I agree. Having some sort of git issue, so abandoning this revision, but the new revision with the renamed font-stack is here: D4356.