Relevant Linear task with full context about keyserver script cleanup here. Added quotes for preventing globbing, removed grep command (and merged with awk). Talked about the fixes and their rationale in more detail in inline comments.
Details
Details
ShellCheck, close reading. Talked about the Test Plan in more detail in the Linear issue, since I did not actually re-run the script. However, since this mainly modifies style, it may not be necessary.
Also, we should plan on adding ShellCheck to the CI as @atul suggested.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Abandoning this, per @ashoat on this Linear task:
We can just delete backup-phabricator.sh… we're using Amazon RDS for the Phabricator database now, which guarantees data integrity out-of-the-box. If we ever find a need for backup-phabricator.sh again we can always just bring it back