Page MenuHomePhabricator
Differential D4479

[native] Clean up `detect_abis.sh`
ClosedPublic
Actions

Authored by • abosh on Jul 7 2022, 8:43 AM.
Tags
None
Referenced Files
F2830465: D4479.id14288.diff
Fri, Sep 27, 7:42 PM
Unknown Object (File)
Fri, Sep 27, 9:00 AM
Unknown Object (File)
Fri, Sep 27, 12:05 AM
Unknown Object (File)
Thu, Sep 26, 6:43 PM
Unknown Object (File)
Tue, Sep 24, 6:49 PM
Unknown Object (File)
Tue, Sep 10, 9:38 PM
Unknown Object (File)
Tue, Sep 10, 9:38 PM
Unknown Object (File)
Tue, Sep 10, 9:38 PM
View All Files
Subscribers
• adrian
tomek

Details

Reviewers
ashoat
atul
• karol
Commits
rCOMM8dd41c6dc66b: [native] Clean up `detect_abis.sh`
Summary

Relevant Linear issue here. More details in inline comments.

Test Plan

ShellCheck, close reading.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• abosh created this revision.Jul 7 2022, 8:43 AM
Herald added subscribers: • adrian, tomek. · View Herald TranscriptJul 7 2022, 8:43 AM
• abosh added inline comments.Jul 7 2022, 8:45 AM
native/android/app/bash/detect_abis.sh
10 ↗(On Diff #14286)

Double quote to prevent globbing and word-splitting.

18 ↗(On Diff #14286)

Double quote to prevent globbing and word-splitting.

atul published this revision for review.Jul 7 2022, 9:02 AM
atul accepted this revision.
This revision is now accepted and ready to land.Jul 7 2022, 9:02 AM
Harbormaster completed remote builds in B10378: Diff 14286.Jul 7 2022, 9:02 AM
Closed by commit rCOMM8dd41c6dc66b: [native] Clean up `detect_abis.sh` (authored by • abosh). · Explain WhyJul 7 2022, 9:06 AM
This revision was automatically updated to reflect the committed changes.
• abosh added a commit: rCOMM8dd41c6dc66b: [native] Clean up `detect_abis.sh`.

Revision Contents
Changeset List

PathSize
native/
android/
app/
bash/
4 lines

Diff 14288

View Options

native/android/app/bash/detect_abis.sh

Loading...