[keyserver] Clean up `run-prod.sh`
AbandonedPublicDraft
Actions

Authored by • abosh on Aug 1 2022, 9:17 AM.

Details

Reviewers

ashoat
atul

Summary

Related Linear issue here. Used ShellCheck to clean up run-prod.sh. This is part of a set of diffs that will allow ShellCheck to be added to the CI.

Test Plan

ShellCheck, close reading

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• abosh created this revision.Aug 1 2022, 9:17 AM

Herald added subscribers: • adrian, tomek. · View Herald TranscriptAug 1 2022, 9:17 AM

• abosh edited the summary of this revision. (Show Details)Aug 1 2022, 9:17 AM

• abosh added inline comments.

keyserver/bash/run-prod.sh
8	Can't follow non-constant source. Use a directive to specify location.

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 1 2022, 9:19 AM

Harbormaster failed remote builds in B11005: Diff 15141!

• abosh mentioned this in D4700: [web] Remove `connectDropTarget` from `ChatMessageList` with new `tooltip` changes.Aug 1 2022, 9:29 AM

• abosh abandoned this revision.Aug 1 2022, 9:59 AM

• abosh mentioned this in D4698: [keyserver] Clean up `scp-backup.sh`.

Revision Contents
Changeset List

Path

Size

keyserver/

bash/

run-prod.sh

1 line

Diff 15141

View Options

keyserver/bash/run-prod.sh

Show First 20 Lines • Show All 326 Lines • ▼ Show 20 Lines	if (Platform.OS === 'ios') {
await this.ensureAndroidPushNotifsEnabled();		await this.ensureAndroidPushNotifsEnabled();
}		}
}		}

async ensureAndroidPushNotifsEnabled() {		async ensureAndroidPushNotifsEnabled() {
const firebase = getFirebase();		const firebase = getFirebase();
const hasPermission = await firebase.messaging().hasPermission();		const hasPermission = await firebase.messaging().hasPermission();
if (!hasPermission) {		if (!hasPermission) {
try {
await firebase.messaging().requestPermission();
} catch {
this.failedToRegisterPushPermissions();		this.failedToRegisterPushPermissions();
return;		return;
}		}
}

const fcmToken = await firebase.messaging().getToken();		const fcmToken = await firebase.messaging().getToken();
if (fcmToken) {		if (fcmToken) {
await this.handleAndroidDeviceToken(fcmToken);		await this.handleAndroidDeviceToken(fcmToken);
} else {		} else {
this.failedToRegisterPushPermissions();		this.failedToRegisterPushPermissions();
}		}
}		}
▲ Show 20 Lines • Show All 278 Lines • Show Last 20 Lines

[keyserver] Clean up `run-prod.sh`AbandonedPublicDraftActions