Page MenuHomePhabricator

[CI] Add “Install ShellCheck” step to ShellCheck GitHub Actions workflow
ClosedPublic

Authored by abosh on Aug 12 2022, 8:42 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 5, 10:40 PM
Unknown Object (File)
Tue, Nov 5, 9:53 PM
Unknown Object (File)
Sun, Nov 3, 2:07 PM
Unknown Object (File)
Oct 7 2024, 11:30 PM
Unknown Object (File)
Oct 7 2024, 11:30 PM
Unknown Object (File)
Oct 7 2024, 11:29 PM
Unknown Object (File)
Oct 7 2024, 11:25 PM
Unknown Object (File)
Sep 28 2024, 6:19 PM
Subscribers

Details

Summary

See this comment left by me for more context, specifically this part:

Also, we could install ShellCheck through apt-get on GitHub Actions to keep it consistent with Buildkite. To do this, we'd just have to revert the changes made in D4756.

On Buildkite, we install ShellCheck through apt-get, so this diff keeps Buildkite and GitHub Actions CI symmetric by installing ShellCheck through the same source.

Test Plan

See what happens on GitHub Actions.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable