[services] Tunnelbroker - Removing a duplicate condition from `waitUntilReady`
ClosedPublic
Actions

Authored by • max on Aug 22 2022, 11:42 AM.

Details

Reviewers

tomek
• karol

Commits

rCOMM6e76f1c96ed5: [services] Tunnelbroker - Removing a duplicate condition from `waitUntilReady`

Summary

This diff is a small follow-up from the landed D4741 comment to remove a duplicate condition from waitUntilReady() function which is covered by the while condition.

Test Plan

Docker:
Run yarn run-tunnelbroker-service successfully built.

Nix:
Run nix develop, cd services/tunnelbroker, rm -dfr build && cmake -B build . && make -C build -j4. Expect successfully building the app.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• max created this revision.Aug 22 2022, 11:42 AM

• max held this revision as a draft.

Herald added subscribers: • abosh, • karol, atul and 2 others. · View Herald TranscriptAug 22 2022, 11:42 AM

• max published this revision for review.Aug 22 2022, 11:46 AM

• max edited the summary of this revision. (Show Details)

• max edited the test plan for this revision. (Show Details)

• max added a reviewer: tomek.

Herald added a reviewer: • karol. · View Herald TranscriptAug 22 2022, 11:47 AM

Harbormaster completed remote builds in B11511: Diff 15832.Aug 22 2022, 11:52 AM

tomek accepted this revision.Aug 23 2022, 1:40 AM

This revision is now accepted and ready to land.Aug 23 2022, 1:40 AM

Closed by commit rCOMM6e76f1c96ed5: [services] Tunnelbroker - Removing a duplicate condition from `waitUntilReady` (authored by • max). · Explain WhyAug 23 2022, 3:49 AM

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMM6e76f1c96ed5: [services] Tunnelbroker - Removing a duplicate condition from `waitUntilReady`.

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

Amqp/

AmqpManager.cpp

3 lines

Diff 15848

View Options

services/tunnelbroker/src/Amqp/AmqpManager.cpp

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines	if (!hasNonce) {
return (		return (
<div className={css.wrapper}>		<div className={css.wrapper}>
<div className={css.walletDisplay}>		<div className={css.walletDisplay}>
<span className={css.walletDisplayText}>Wallet Connected:</span>		<span className={css.walletDisplayText}>Wallet Connected:</span>
<ConnectButton />		<ConnectButton />
</div>		</div>
<p>{siweMessageSigningExplanationStatements[0]}</p>		<p>{siweMessageSigningExplanationStatements[0]}</p>
<p>{siweMessageSigningExplanationStatements[1]}</p>		<p>{siweMessageSigningExplanationStatements[1]}</p>
		<p>
		By signing up, you agree to our{' '}
		<a href="https://comm.app/terms">Terms of Use</a> &{' '}
		<a href="https://comm.app/privacy">Privacy Policy</a>.
		</p>
<div className={css.button} onClick={onClick}>		<div className={css.button} onClick={onClick}>
Sign in		Sign in
</div>		</div>
</div>		</div>
);		);
}		}
}		}

Show All 22 Lines

[services] Tunnelbroker - Removing a duplicate condition from `waitUntilReady`ClosedPublicActions