Page MenuHomePhabricator

[landing] fixed fatal bundling issue using window outside function scope
ClosedPublic

Authored by derek on Aug 26 2022, 11:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 28, 5:07 AM
Unknown Object (File)
Mon, Oct 28, 5:07 AM
Unknown Object (File)
Mon, Oct 28, 5:05 AM
Unknown Object (File)
Sun, Oct 6, 2:09 PM
Unknown Object (File)
Sep 23 2024, 4:16 PM
Unknown Object (File)
Sep 16 2024, 2:22 PM
Unknown Object (File)
Sep 16 2024, 2:22 PM
Unknown Object (File)
Sep 16 2024, 2:21 PM

Details

Summary

after merging D4510, for some reason, there is an issue bundling with using the global variable window in the global scope as opposed to inside a function scope. it results in this error message:

Could not load landing.build.cjs. Did you forget to run `yarn dev` in the landing folder?
at getWebpackCompiledRootComponentForSSR (file:///Users/derek/clients/comm/keyserver/dist/responders/landing-handler.js:84:11)
Test Plan

run yarn dev and be able to visit /landing instead of being greeted by a fatal error

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable