Differential D4961

[native] Use `values(...)` in `InputStateContainer`
ClosedPublic
Actions

Authored by • abosh on Aug 26 2022, 1:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Apr 13, 4:56 AM

	Unknown Object (File)
	Wed, Apr 9, 12:10 AM

	Unknown Object (File)
	Tue, Apr 8, 10:55 PM

	Unknown Object (File)
	Tue, Apr 8, 10:55 PM

	Unknown Object (File)
	Tue, Apr 8, 10:55 PM

	Unknown Object (File)
	Tue, Apr 8, 10:55 PM

	Unknown Object (File)
	Fri, Apr 4, 2:08 PM

	Unknown Object (File)
	Fri, Apr 4, 2:08 PM

Subscribers

Details

Reviewers

atul
tomek

Commits

rCOMM08dfbbfd79e7: [native] Use `values(...)` in `InputStateContainer`

Summary

Saw @ashoat's comment on D4892.

Test Plan

Flow, close reading.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• abosh created this revision.Aug 26 2022, 1:41 PM

• abosh edited the summary of this revision. (Show Details)Aug 26 2022, 1:41 PM

Harbormaster completed remote builds in B11647: Diff 16021.Aug 26 2022, 1:51 PM

• abosh requested review of this revision.Aug 26 2022, 1:51 PM

tomek accepted this revision.Aug 29 2022, 9:16 AM

This revision is now accepted and ready to land.Aug 29 2022, 9:16 AM

Closed by commit rCOMM08dfbbfd79e7: [native] Use `values(...)` in `InputStateContainer` (authored by • abosh). · Explain WhyAug 29 2022, 10:17 AM

This revision was automatically updated to reflect the committed changes.

• abosh added a commit: rCOMM08dfbbfd79e7: [native] Use `values(...)` in `InputStateContainer`.

Revision Contents
Changeset List

Path

Size

native/

input/

input-state-container.react.js

14 lines

Diff 16075

native/input/input-state-container.react.js

This file was added.

				// @flow

				import * as React from 'react';

				import {
				relationshipActions,
				userRelationshipStatus,
				} from 'lib/types/relationship-types.js';

				import AddUsersListModal from './add-users-list-modal.react';

				const excludedStatuses = new Set([
				userRelationshipStatus.FRIEND,
				userRelationshipStatus.BLOCKED_VIEWER,
				userRelationshipStatus.BOTH_BLOCKED,
				userRelationshipStatus.REQUEST_SENT,
				userRelationshipStatus.REQUEST_RECEIVED,
				]);

				type Props = {
				+onClose: () => void,
				};

				function AddFriendsModal(props: Props): React.Node {
				const { onClose } = props;

				return (
				<AddUsersListModal
				closeModal={onClose}
				name="Add Friends"
				excludedStatuses={excludedStatuses}
				confirmButtonContent="Send Friend Requests"
				relationshipAction={relationshipActions.FRIEND}
				/>
				);
				}

				export default AddFriendsModal;