[native] Removing gRPC C++ deleted files from the XCode project
ClosedPublic
Actions

Authored by • max on Nov 30 2022, 3:23 AM.

Details

Reviewers

atul
ashoat

Commits

rCOMMbc81f2858c4a: [native] Removing gRPC C++ deleted files from the XCode project

Summary

Removing of gRPC C++ already deleted files from the XCode project. This is a follow-up from D5706 where files were deleted.

Linear task: ENG-2276

Test Plan

Open XCode project -> navigate to the "Project navigator" (folder icon). Expand all folders to show files. There are no red-marked files (missing files).
The iOS app is successfully built.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• max created this revision.Nov 30 2022, 3:23 AM

• max held this revision as a draft.

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptNov 30 2022, 3:23 AM

• max edited the summary of this revision. (Show Details)Nov 30 2022, 3:26 AM

• max edited the test plan for this revision. (Show Details)

• max added reviewers: atul, ashoat.

• max published this revision for review.Nov 30 2022, 3:28 AM

• max edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B13877: Diff 19001.Nov 30 2022, 3:35 AM

Hard to review this without opening up in Xcode, so will have to rely on @max's testing.

That said, I think the test plan is not good... the app builds in Xcode either way. Instead, can you modify the test plan to include opening up Xcode, and verifying there are no red entries in the file view (folder icon on the left pane) except for CommRelease?

If that looks good then feel free to land!

This revision is now accepted and ready to land.Nov 30 2022, 5:47 AM

That said, I think the test plan is not good... the app builds in Xcode either way. Instead, can you modify the test plan to include opening up Xcode, and verifying there are no red entries in the file view (folder icon on the left pane) except for CommRelease?

Makes sense to change it. Done!

Closed by commit rCOMMbc81f2858c4a: [native] Removing gRPC C++ deleted files from the XCode project (authored by • max). · Explain WhyNov 30 2022, 6:56 AM

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMMbc81f2858c4a: [native] Removing gRPC C++ deleted files from the XCode project.