Page MenuHomePhabricator

[native] Update comment explaining sleep in Entry on native
ClosedPublic

Authored by ashoat on Dec 17 2022, 7:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 18, 8:02 AM
Unknown Object (File)
Thu, Jun 13, 4:53 PM
Unknown Object (File)
Thu, Jun 13, 10:05 AM
Unknown Object (File)
Tue, Jun 11, 7:40 AM
Unknown Object (File)
Mon, Jun 3, 9:13 PM
Unknown Object (File)
May 30 2024, 9:23 PM
Unknown Object (File)
May 25 2024, 4:40 AM
Unknown Object (File)
May 25 2024, 4:40 AM
Subscribers

Details

Summary

I remember what this comment was initially referring to. Way back in the past, when we rendered a TextInput for every Entry regardless of whether it was active or not, we had an issue where the scroll animation for new Entry creation was getting stopped partway through when the TextInput focused.

This hack appears to no longer be necessary to avoid that issue. However, it turns out removing the hack had a different side-effect, resulting from our new behavior of only rendering a TextInput for an active Entry. The hack appears to now be necessary for a different reason, which is explained in the updated comment.

Test Plan

Confirm that removing the hack has the effect described in the updated comment, and that removing the hack does not have the effect described in the original comment

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 17 2022, 9:32 PM
Harbormaster failed remote builds in B14222: Diff 19456!

Something is broken with iOS CI

This revision is now accepted and ready to land.Dec 19 2022, 2:15 AM