Page MenuHomePhabricator
Differential D6173

[native/rust_library] Revert: Adding `openssl`, `base64`, `anyhow` dependencies"
ClosedPublic
Actions

Authored by • max on Jan 5 2023, 1:42 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 8:31 PM
Unknown Object (File)
Thu, Nov 14, 5:45 PM
Unknown Object (File)
Mon, Nov 4, 6:24 AM
Unknown Object (File)
Mon, Nov 4, 6:16 AM
Unknown Object (File)
Sun, Nov 3, 1:16 AM
Unknown Object (File)
Sun, Nov 3, 1:15 AM
Unknown Object (File)
Sun, Nov 3, 1:15 AM
Unknown Object (File)
Sun, Nov 3, 1:13 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
ashoat
tomek
Commits
rCOMM5f4cc9324721: [native/rust_library] Revert: Adding `openssl`, `base64`, `anyhow` dependencies"
Summary

This diff reverts the D6079 changes because of GitHub Actions iOS build fails with the unsupported architecture error.

Linear task: ENG-2643

Test Plan

No test plan.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• max created this revision.Jan 5 2023, 1:42 AM
• max held this revision as a draft.
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 5 2023, 1:42 AM
• max published this revision for review.Jan 5 2023, 1:48 AM
• max retitled this revision from Revert "[native/rust_library] Adding `openssl`, `base64`, `anyhow` dependencies" to [native/rust_library] Revert: Adding `openssl`, `base64`, `anyhow` dependencies".
• max edited the summary of this revision. (Show Details)
• max edited the test plan for this revision. (Show Details)
• max added reviewers: ashoat, tomek.
Harbormaster completed remote builds in B15102: Diff 20597.Jan 5 2023, 1:55 AM
ashoat accepted this revision.Jan 5 2023, 9:03 AM
This revision is now accepted and ready to land.Jan 5 2023, 9:03 AM
tomek accepted this revision.Jan 5 2023, 9:06 AM

Have you followed this https://www.notion.so/commapp/How-to-revert-a-diff-dcdcd83a09b248b2a3e03372103786e9 guide? This should result in a summary that contains a hash of reverted commit, like e.g. in D6079.

But the important question is that the summary mentions that this diff reverts D6079 while in fact it does exactly the same thing as that diff?

Closed by commit rCOMM5f4cc9324721: [native/rust_library] Revert: Adding `openssl`, `base64`, `anyhow` dependencies" (authored by • max). · Explain WhyJan 5 2023, 9:17 AM
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMM5f4cc9324721: [native/rust_library] Revert: Adding `openssl`, `base64`, `anyhow` dependencies".

Revision Contents
Changeset List

PathSize
native/
native_rust_library/
3 lines

Diff 20626

View Options

native/native_rust_library/Cargo.lock

Loading...
View Options

native/native_rust_library/Cargo.toml

Loading...