[keyserver] Ensure that we're including `calendarQuery` in `siweAccountCreationRequest`
ClosedPublic
Actions

Authored by atul on Jan 22 2023, 5:37 PM.

Details

Reviewers

ashoat
tomek

Commits

Summary

This is needed for successful registration when we call the siwe_auth endpoint from web. I should have included this earlier.

Test Plan

Able to step through account creation and ensure that every step completes as expected.

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

atul published this revision for review.Jan 22 2023, 5:38 PM

atul planned changes to this revision.Jan 22 2023, 5:58 PM

atul requested review of this revision.Jan 22 2023, 6:01 PM

ashoat requested changes to this revision.Jan 23 2023, 9:17 AM

ashoat added inline comments.

keyserver/src/creators/account-creator.js
223 ↗	(On Diff #21181)	We don't seem to do anything with this!! Let's get rid of the `promises` array and actually `await` it, presumably before the calls below that actually create the user
236 ↗	(On Diff #21181)	I think this is a duplicate call, see ENG-2767. Can we just remove it?

This revision now requires changes to proceed.Jan 23 2023, 9:17 AM

address feedback

keyserver/src/creators/account-creator.js
223 ↗	(On Diff #21181)	I'm not sure how I missed that..... going to read through `processSIWEAccountCreation` and `processSuccessfulLogin` again to make sure everything is correct.
236 ↗	(On Diff #21181)	Can we just remove it? If none of the subsequent queries that use the `Viewer` object (eg `createPrivateThread(viewer, request.address)` depend on the cookie being set correctly. I'll read through and handle ENG-2767 in subsequent diff.