Details
Works as expected:
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| web/account/siwe.react.js | ||
|---|---|---|
| 93–97 ↗ | (On Diff #21183) | This could be inverted to reduce indentation, but I think it's a little easier to reason about as is. Open to changing it if that's what others would prefer. |
Mainly requesting changes for the question about unsetting hasSIWEButtonBeenClicked
| web/account/siwe.react.js | ||
|---|---|---|
| 109–112 ↗ | (On Diff #21183) | We can replace all four of these inputs with a single boolean, which will reduce the number of times this effect executes needlessly |
| 180 ↗ | (On Diff #21183) | What if the users backs out to the initial screen... won't we need to unset this value? |
| web/account/siwe.react.js | ||
|---|---|---|
| 180 ↗ | (On Diff #21183) | We will once we have implemented the navigational structure in the designs provided by David, but there's no such thing as the user "back[ing] out to the initial screen" for now. But yeah once we have that back button we'll want to call setHasSIWEButtonBeenClicked(false). |
| web/account/siwe.react.js | ||
|---|---|---|
| 92–95 ↗ | (On Diff #21230) | Is this what you meant? |
| web/account/siwe.react.js | ||
|---|---|---|
| 92–95 ↗ | (On Diff #21230) | Yup |