[web] Pull `SIWEButton` out of `SIWE` component and use in `LogInForm` directly
ClosedPublic
Actions

Authored by atul on Feb 1 2023, 12:35 PM.

Details

Reviewers

ashoat
tomek

Commits

rCOMMfb73711a58ff: [web] Pull `SIWEButton` out of `SIWE` component and use in `LogInForm` directly

Summary

Pull SIWEButton out of SIWE component and use in LogInForm component directly. This allows us to render SIWEButton OR SIWE.

In following diffs will display traditional login form and SIWEButton OR just SIWE WITHOUT traditional login form.

Test Plan

If the user has a wallet connected (signer is truthy) and refreshes the page they will be shown SIWEButton and will need to click it again to see SIWELoginForm

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Feb 1 2023, 12:35 PM

atul edited the summary of this revision. (Show Details)Feb 1 2023, 12:36 PM

atul edited the test plan for this revision. (Show Details)

atul published this revision for review.Feb 1 2023, 12:40 PM

Harbormaster completed remote builds in B15950: Diff 21782.Feb 1 2023, 12:54 PM

Didn't review closely

web/account/log-in-form.react.js
145 ↗	(On Diff #21782)	I don't think this is a no-op – the behavior changes if the user is logged in with ETH and refreshes the page, right?

This revision is now accepted and ready to land.Feb 1 2023, 1:09 PM

atul added inline comments.Feb 1 2023, 1:11 PM

web/account/log-in-form.react.js
145 ↗	(On Diff #21782)	Ah yeah, this does require the user to hit the "Sign in with Ethereum" button in order to see the SIWE statements and "Sign in" button on reload.