[lib] Increase ENS cache query timeout to 10s
ClosedPublic
Actions

Authored by ashoat on Feb 16 2023, 3:11 PM.

Details

Reviewers

atul

Commits

rCOMM7358f4a66ef5: [lib] Increase ENS cache query timeout to 10s

Summary

This keeps timing out in my dev environment, which is annoying.

Open to making it 10s only in __DEV__, but I figured it didn't hurt to do this for prod too... perhaps in situations with bad connectivity, this isn't unusual for Alchemy?

Test Plan

Confirm that ENS names are now loaded on my iOS Simulator while testing

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Feb 16 2023, 3:11 PM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 16 2023, 3:11 PM

Update comment

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 16 2023, 3:14 PM

Harbormaster failed remote builds in B16558: Diff 22654!

Harbormaster completed remote builds in B16557: Diff 22653.Feb 16 2023, 3:27 PM

Harbormaster completed remote builds in B16558: Diff 22654.Feb 16 2023, 5:51 PM

ashoat requested review of this revision.Feb 16 2023, 5:51 PM

atul accepted this revision.Feb 16 2023, 6:27 PM

This revision is now accepted and ready to land.Feb 16 2023, 6:27 PM

Closed by commit rCOMM7358f4a66ef5: [lib] Increase ENS cache query timeout to 10s. · Explain WhyFeb 16 2023, 7:33 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM7358f4a66ef5: [lib] Increase ENS cache query timeout to 10s.

Revision Contents
Changeset List

Path

Size

lib/

utils/

ens-cache.js

2 lines

Diff 22658

View Options

[lib] Increase ENS cache query timeout to 10sClosedPublicActions