Page MenuHomePhabricator
Differential D6767

[native] Emit artificial onSelectionChange alongside onChangeText in ClearableTextInput
ClosedPublic
Actions

Authored by ashoat on Feb 18 2023, 12:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 23, 7:43 AM
Unknown Object (File)
Sun, Dec 22, 4:19 PM
Unknown Object (File)
Sun, Dec 22, 4:18 PM
Unknown Object (File)
Sun, Dec 22, 4:18 PM
Unknown Object (File)
Sun, Dec 22, 4:18 PM
Unknown Object (File)
Nov 1 2024, 11:17 AM
Unknown Object (File)
Nov 1 2024, 11:16 AM
Unknown Object (File)
Nov 1 2024, 11:16 AM
View All Files
Subscribers
None

Details

Reviewers
tomek
atul
Commits
rCOMM2ac2534d7dc1: [native] Emit artificial onSelectionChange alongside onChangeText in…
Summary

When clearing the input in ClearableTextInput, we construct an artificial onChangeText event. This confuses SelectableTextInput, which expects that onChangeText events should always be accompanied by onSelectionChange events.

As a result of this interaction, a bug occurs because ClearableTextInput defers emiting an onUpdateSyncedSelectionData event until it receives the corresponding onSelectionChange.

This diff addresses the issues by adding an artificial onSelectionChange event alongside the artificial onChangeText event. On iOS onSelectionChange comes first, but on Android it comes last.

Test Plan

Before this change, I had noticed a bug where the @-mention typeahead would not clear after text input cleared. After this change the issue was gone.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Feb 18 2023, 12:11 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 18 2023, 12:27 PM
Harbormaster failed remote builds in B16594: Diff 22700!
ashoat updated this revision to Diff 22743.Feb 20 2023, 12:26 PM

Rebase on master to fix CI

Harbormaster completed remote builds in B16632: Diff 22743.Feb 20 2023, 12:41 PM
ashoat requested review of this revision.Feb 20 2023, 12:41 PM
atul accepted this revision.Feb 20 2023, 2:28 PM

Before this change, I had noticed a bug where the @-mention typeahead would not clear after text input cleared. After this change the issue was gone.

Based on Summary, assuming this was tested on both iOS and Android

native/components/clearable-text-input.react.ios.js
117–121 ↗(On Diff #22743)

Thanks for including this explanation

This revision is now accepted and ready to land.Feb 20 2023, 2:28 PM
Closed by commit rCOMM2ac2534d7dc1: [native] Emit artificial onSelectionChange alongside onChangeText in… (authored by ashoat). · Explain WhyFeb 20 2023, 3:03 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM2ac2534d7dc1: [native] Emit artificial onSelectionChange alongside onChangeText in….

Revision Contents
Changeset List

PathSize
native/
components/
15 lines
14 lines

Diff 22761

View Options

native/components/clearable-text-input.react.ios.js

Loading...
View Options

native/components/clearable-text-input.react.js

Loading...