Page MenuHomePhabricator
Differential D6901

[keyserver] Introduce `getOLMUtility(...)` and initialize OLM on `keyserver` start
ClosedPublic
Actions

Authored by atul on Feb 27 2023, 1:57 PM.
Tags
None
Referenced Files
F5058721: D6901.id23189.diff
Wed, Mar 26, 7:08 AM
Unknown Object (File)
Sun, Mar 2, 8:58 PM
Unknown Object (File)
Mon, Feb 24, 11:01 PM
Unknown Object (File)
Jan 30 2025, 4:33 PM
Unknown Object (File)
Jan 30 2025, 4:33 PM
Unknown Object (File)
Jan 30 2025, 4:33 PM
Unknown Object (File)
Jan 30 2025, 4:33 PM
Unknown Object (File)
Jan 30 2025, 9:07 AM
View All Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM06732ac6a7f2: [keyserver] Introduce `getOLMUtility(...)` and initialize OLM on `keyserver`…
Summary

Initialize OLM by calling await olm.init() on keyserver start and introduce getOLMUtility to potentially access cached OLMUtility... or instantiate a new one.

Test Plan
  • Logged in a bunch of times and ensured things worked as expected.
  • Set breakpoint on cache hit:

8fe3ee.png (632×1 px, 147 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Feb 27 2023, 1:57 PM
atul published this revision for review.Feb 27 2023, 1:58 PM
atul mentioned this in D6897: [keyserver] Verify `signedIdentityKeysBlob` signature in `logInResponder`.
atul updated this revision to Diff 23179.Feb 27 2023, 1:59 PM

annotate

atul edited the test plan for this revision. (Show Details)Feb 27 2023, 1:59 PM
Harbormaster completed remote builds in B16957: Diff 23178.Feb 27 2023, 2:13 PM
Harbormaster completed remote builds in B16958: Diff 23179.
ashoat accepted this revision.Feb 27 2023, 2:35 PM
This revision is now accepted and ready to land.Feb 27 2023, 2:35 PM
atul updated this revision to Diff 23188.Feb 27 2023, 3:20 PM

rebase + land

This revision was landed with ongoing or failed builds.Feb 27 2023, 3:20 PM
Closed by commit rCOMM06732ac6a7f2: [keyserver] Introduce `getOLMUtility(...)` and initialize OLM on `keyserver`… (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM06732ac6a7f2: [keyserver] Introduce `getOLMUtility(...)` and initialize OLM on `keyserver`….
Harbormaster completed remote builds in B16965: Diff 23188.Feb 27 2023, 3:34 PM
ashoat mentioned this in D6923: [keyserver] Tunnelbroker integration - Adding Tunnelbroker publisher and connector.Mar 2 2023, 7:53 AM

Revision Contents
Changeset List

PathSize
keyserver/
src/
2 lines
responders/
6 lines
utils/
12 lines

Diff 23189

View Options

keyserver/src/keyserver.js

Show All 31 Lines.questionText {
color: var(--white-100); color: var(--white-100);
} }
.icon { .icon {
margin-left: 24px; margin-left: 24px;
} }
.answerContainer { .answerContainer {
max-height: 0; display: grid;
overflow: hidden; grid-template-rows: 0fr;
transition: grid-template-rows 500ms;
} }
.activeAnswerContainer { .activeAnswerContainer {
max-height: fit-content; grid-template-rows: 1fr;
} }
.answerText { .answerText {
color: var(--white-100); color: var(--white-100);
margin-top: 16px; margin-top: 16px;
overflow: hidden;
} }
.link { .link {
color: inherit; color: inherit;
text-decoration: underline; text-decoration: underline;
transition: color 150ms; transition: color 150ms;
} }
.link:hover { .link:hover {
color: var(--violet-dark-100); color: var(--violet-dark-100);
transition: color 150ms; transition: color 150ms;
} }
View Options

keyserver/src/responders/user-responders.js

Show All 31 Lines.questionText {
color: var(--white-100); color: var(--white-100);
} }
.icon { .icon {
margin-left: 24px; margin-left: 24px;
} }
.answerContainer { .answerContainer {
max-height: 0; display: grid;
overflow: hidden; grid-template-rows: 0fr;
transition: grid-template-rows 500ms;
} }
.activeAnswerContainer { .activeAnswerContainer {
max-height: fit-content; grid-template-rows: 1fr;
} }
.answerText { .answerText {
color: var(--white-100); color: var(--white-100);
margin-top: 16px; margin-top: 16px;
overflow: hidden;
} }
.link { .link {
color: inherit; color: inherit;
text-decoration: underline; text-decoration: underline;
transition: color 150ms; transition: color 150ms;
} }
.link:hover { .link:hover {
color: var(--violet-dark-100); color: var(--violet-dark-100);
transition: color 150ms; transition: color 150ms;
} }
View Options

keyserver/src/utils/olm-utils.js

Show All 31 Lines.questionText {
color: var(--white-100); color: var(--white-100);
} }
.icon { .icon {
margin-left: 24px; margin-left: 24px;
} }
.answerContainer { .answerContainer {
max-height: 0; display: grid;
overflow: hidden; grid-template-rows: 0fr;
transition: grid-template-rows 500ms;
} }
.activeAnswerContainer { .activeAnswerContainer {
max-height: fit-content; grid-template-rows: 1fr;
} }
.answerText { .answerText {
color: var(--white-100); color: var(--white-100);
margin-top: 16px; margin-top: 16px;
overflow: hidden;
} }
.link { .link {
color: inherit; color: inherit;
text-decoration: underline; text-decoration: underline;
transition: color 150ms; transition: color 150ms;
} }
.link:hover { .link:hover {
color: var(--violet-dark-100); color: var(--violet-dark-100);
transition: color 150ms; transition: color 150ms;
} }