Page MenuHomePhabricator
Differential D6956

[lib] Add `getSignedIdentityKeysBlob` to `getClientResponsesSelector`
ClosedPublic
Actions

Authored by atul on Mar 5 2023, 4:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 3, 10:36 PM
Unknown Object (File)
Wed, Oct 30, 6:52 AM
Unknown Object (File)
Wed, Oct 30, 6:52 AM
Unknown Object (File)
Wed, Oct 30, 6:52 AM
Unknown Object (File)
Wed, Oct 30, 6:52 AM
Unknown Object (File)
Wed, Oct 30, 6:51 AM
Unknown Object (File)
Oct 21 2024, 12:40 PM
Unknown Object (File)
Oct 18 2024, 10:00 AM
View All Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM797ae5e79070: [lib] Add `getSignedIdentityKeysBlob` to `getClientResponsesSelector`
Summary

Include getSignedIdentityKeysBlob to getClientResponsesSelector

Test Plan

getSignedIdentityKeysBlob will be implemented for native and web in subsequent diffs. For now things continue to work as they did (verified with some basic logging + breakpoints).

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Mar 5 2023, 4:03 PM
atul published this revision for review.Mar 5 2023, 4:05 PM
atul added inline comments.
native/selectors/socket-selectors.js
65 ↗(On Diff #23461)

On native the data required to derive signedIdentityKeysBlob is not stored in Redux, so we pass a function that can make the JSI call and construct signedIdentityKeysBlob as needed.

Harbormaster completed remote builds in B17126: Diff 23461.Mar 5 2023, 4:18 PM
ashoat accepted this revision.Mar 6 2023, 6:03 AM
This revision is now accepted and ready to land.Mar 6 2023, 6:03 AM
atul updated this revision to Diff 23465.Mar 6 2023, 10:00 AM

rebase + land

Harbormaster completed remote builds in B17128: Diff 23465.Mar 6 2023, 10:16 AM
Closed by commit rCOMM797ae5e79070: [lib] Add `getSignedIdentityKeysBlob` to `getClientResponsesSelector` (authored by atul). · Explain WhyMar 6 2023, 10:18 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM797ae5e79070: [lib] Add `getSignedIdentityKeysBlob` to `getClientResponsesSelector`.

Revision Contents
Changeset List

PathSize
lib/
selectors/
12 lines
native/
selectors/
3 lines
web/
selectors/
4 lines

Diff 23466

View Options

lib/selectors/socket-selectors.js

Loading...
View Options

native/selectors/socket-selectors.js

Loading...
View Options

web/selectors/socket-selectors.js

Loading...